[webkit-reviews] review denied: [Bug 19751] Merge LogicalAndNode and LogicalOrNode to LogicalOpNode : [Attachment 21910] Patch to merge LogicalAndNode and LogicalOrNode

[bugzilla-daemon at webkit.org]

Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has denied Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 19751: Merge LogicalAndNode and LogicalOrNode to LogicalOpNode
https://bugs.webkit.org/show_bug.cgi?id=19751

Attachment 21910: Patch to merge LogicalAndNode and LogicalOrNode
https://bugs.webkit.org/attachment.cgi?id=21910&action=edit

------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
I like the idea of this patch a lot. I have been thinking of doing this for
other node types, including UnaryOpNode, BinaryOpNode, and the ones you have
already done.

The only thing I don't like about this patch is that you add more cases to the
Operator enum. I would prefer a separate enum for OpLogicalOr and OpLogicalAnd.
Change that and I'll review it.