[webkit-reviews] review granted: [Bug 19663] Image animation timers do not account for paint lag : [Attachment 21886] patch v4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 23 13:26:42 PDT 2008

Darin Adler <darin at apple.com> has granted Peter Kasting <zerodpx at gmail.com>'s
request for review:
Bug 19663: Image animation timers do not account for paint lag

Attachment 21886: patch v4

------- Additional Comments from Darin Adler <darin at apple.com>
+    double currentDuration = frameDurationAtIndex(m_currentFrame);
+    const double time = currentTime();

It's OK to use const to emphasize that a local variable won't be changed, but
we rarely do that in WebKit code. It's a little strange to do it for "time" and
not for "currentDuration" since neither is intended to change.

I suggest just leaving it out.

r=me as-is, although I'd take out that const if I was landing the patch

More information about the webkit-reviews mailing list