[webkit-reviews] review granted: [Bug 19727] Return bool from GraphicsContext::getShadow() so the tests aren't duplicated so many times in Cairo and Qt ports : [Attachment 21887] Updated patch which returns bool from getShadow()

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jonathon Jongsma
<jonathon.jongsma at collabora.co.uk>'s request for review:
Bug 19727: Return bool from GraphicsContext::getShadow() so the tests aren't
duplicated so many times in Cairo and Qt ports
https://bugs.webkit.org/show_bug.cgi?id=19727

Attachment 21887: Updated patch which returns bool from getShadow()
https://bugs.webkit.org/attachment.cgi?id=21887&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+    return color.isValid() && color.alpha() &&
+	 (blur || m_common->state.shadowSize.width() ||
m_common->state.shadowSize.height());

Heh, I just realized that invalid colors are guaranteed to have an alpha of 0,
so you don't need the isValid check at all.

+	 (blur || m_common->state.shadowSize.width() ||
m_common->state.shadowSize.height());

Why not use size here instead of m_common->state.shadowSize?

r=me