[webkit-reviews] review requested: [Bug 19727] Add GraphicsContext::hasShadow() so the tests aren't duplicated so many times in Cairo and Qt ports : [Attachment 21887] Updated patch which returns bool from getShadow()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 23 12:23:05 PDT 2008


Jonathon Jongsma <jonathon.jongsma at collabora.co.uk> has asked  for review:
Bug 19727: Add GraphicsContext::hasShadow() so the tests aren't duplicated so
many times in Cairo and Qt ports
https://bugs.webkit.org/show_bug.cgi?id=19727

Attachment 21887: Updated patch which returns bool from getShadow()
https://bugs.webkit.org/attachment.cgi?id=21887&action=edit

------- Additional Comments from Jonathon Jongsma
<jonathon.jongsma at collabora.co.uk>
This patch should address the comments from both darin and mitz.  Also, just in
case it's not obvious, this patch depends on the patch in Bug #18459 which adds
text-shadow support to the Qt port.  This patch was submitted separately since
it affeccts more than just the Qt port, but it can't really be applied until
the other patch is applied.


More information about the webkit-reviews mailing list