[webkit-reviews] review denied: [Bug 19663] Image animation timers do not account for paint lag : [Attachment 21864] patch v3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 23 10:55:22 PDT 2008

Darin Adler <darin at apple.com> has denied Peter Kasting <zerodpx at gmail.com>'s
request for review:
Bug 19663: Image animation timers do not account for paint lag

Attachment 21864: patch v3

------- Additional Comments from Darin Adler <darin at apple.com>
The approach looks good.

Needs a ChangeLog; I'd have to say review- just because of that.

I'm concerned, as you are, that the loop in BitmapImage::startAnimation can run
for a long time. Is there any way for us to prevent pathologically slow case

+	     nextFrame = (++nextFrame) % frameCount();

Modifying nextFrame on the right side and the left is not legal C, and can have
undefined behavior depending on the compiler. The right side must say
"nextFrame + 1" rather than "++nextFrame".

review- just because of this ++nextFrame issue, but this looks about ready to

More information about the webkit-reviews mailing list