[webkit-reviews] review denied: [Bug 18987] [GTK] Implement SharedBuffer::createWithContentsOfFile and KURL::fileSystemPath : [Attachment 21080] Implement the missing functions and use g_file_contents() to read the file

[bugzilla-daemon at webkit.org]

Holger Freyther <freyther at handhelds.org> has denied Marco Barisione
<marco.barisione at collabora.co.uk>'s request for review:
Bug 18987: [GTK] Implement SharedBuffer::createWithContentsOfFile and
KURL::fileSystemPath
https://bugs.webkit.org/show_bug.cgi?id=18987

Attachment 21080: Implement the missing functions and use g_file_contents() to
read the file
https://bugs.webkit.org/attachment.cgi?id=21080&action=edit

------- Additional Comments from Holger Freyther <freyther at handhelds.org>
Sorry, I have to say r=- on this one. I will be on irc tomorrow we can resolve
this and land the patch without waiting another month.

comments:
   - the goto is unusual, we tend to use early exits
   - KURL::fileSystemPath does not work with utf8 encoded paths as String
path(char*) works only on latin1.