[webkit-reviews] review denied: [Bug 19331] Drag and drop of links in edit mode violates assert in MoveSelectionCommand::doApply() : [Attachment 21509] Expand the selection to the enclosing anchor element at the drag launch per comment by Olliver

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 22 22:39:38 PDT 2008


Oliver Hunt <oliver at apple.com> has denied Jonathon Jongsma
<jonathon.jongsma at collabora.co.uk>'s request for review:
Bug 19331: Drag and drop of links in edit mode violates assert in
MoveSelectionCommand::doApply()
https://bugs.webkit.org/show_bug.cgi?id=19331

Attachment 21509: Expand the selection to the enclosing anchor element at the
drag launch per comment by Olliver
https://bugs.webkit.org/attachment.cgi?id=21509&action=edit

------- Additional Comments from Oliver Hunt <oliver at apple.com>
The selection should not be modified unless EditableLinkBehavior is set to an
appropriate setting, otherwise the logic looks fine.

Minor style issue -- if (node) ... should not have braces as it is a single
line block 

Otherwise this looks good.


More information about the webkit-reviews mailing list