[webkit-reviews] review requested: [Bug 9214] Images using QT plugin do not display correctly : [Attachment 21875] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 22 14:06:49 PDT 2008

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 9214: Images using QT plugin do not display correctly

Attachment 21875: Patch v1

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Proposed patch.

HTMLEmbedObject::isImageType() was copied directly from HTMLObjectElement. 
Should I create a base class for HTMLEmbedElement and HTMLObjectElement, or
move common methods to HTMLPlugInElement?    Note that HTMLAppletElement also
inherits from HTMLPlugInElement, which wouldn't used some member variables or

(The changes to HTMLObjectElement were to make extracting member variables and
methods to a base class easier.)

More information about the webkit-reviews mailing list