[webkit-reviews] review denied: [Bug 17267] [GTK] Primary selection/clipboard support : [Attachment 21872] Attempt at primary clipboard support

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Christian Dywan
<christian at imendio.com>'s request for review:
Bug 17267: [GTK] Primary selection/clipboard support
https://bugs.webkit.org/show_bug.cgi?id=17267

Attachment 21872: Attempt at primary clipboard support
https://bugs.webkit.org/attachment.cgi?id=21872&action=edit

------- Additional Comments from Oliver Hunt <oliver at apple.com>
r-, the shouldBlah methods are callbacks made to the api to query whether
something is allowed, not that is has already happened.

EditorClient methods are (by and large) just present to allow WebCore's
behaviour to be controlled through the platforms API, so all these methods
should just map through to your API implementation.

The WebKit/GTK API's default implementation for didChangeSelectedRange (or
whatever, definitely not shouldChangeSelectedRange) would probably be something
along these lines.