[webkit-reviews] review denied: [Bug 12425] border-radius not applied to fieldset with legend : [Attachment 21868] Method two: using a clipping region with no border radius speed up

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied Alex Taylor <darwin at milliamp.org>'s request for
review:
Bug 12425: border-radius not applied to fieldset with legend
https://bugs.webkit.org/show_bug.cgi?id=12425

Attachment 21868: Method two: using a clipping region with no border radius
speed up
https://bugs.webkit.org/attachment.cgi?id=21868&action=edit

------- Additional Comments from mitz at webkit.org
Looks good! A few comments:

1) Please add the bug URL and title to the change log and add change log
comments about the code changes in each function.

2) Won't this paint fill layers a second time (except behind the legend)?

+    RenderBlock::paintBoxDecorations(paintInfo, tx, ty);

Why are you not calling just paintBorder()?

3) Likewise, the change log for LayoutTests should include a reference to the
bug. You should generate results (including pixel results) and include them in
the patch.

4) Please add newlines:
\ No newline at end of file

5) I think a single test containing the three separate cases would be better
(make sure everything fits into the 800x600 rectangle that's included in pixel
test results). Maybe something like
LayoutTests/fast/block/basic/fieldset-stretch-to-legend.html , only adding
border-radius, to cover all interesting cases.

r- for now mostly because of 2)