[webkit-reviews] review requested: [Bug 18459] text-shadow is not implemented : [Attachment 21843] Add text-shadow to the Qt port

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 19 11:39:17 PDT 2008

Jonathon Jongsma <jonathon.jongsma at collabora.co.uk> has asked  for review:
Bug 18459: text-shadow is not implemented

Attachment 21843: Add text-shadow to the Qt port

------- Additional Comments from Jonathon Jongsma
<jonathon.jongsma at collabora.co.uk>
Here's a potential Fix.  I also noticed that there's a commented-out function
GraphicsContext::drawTextShadow() that seems to be out-of-date.  I assume this
was written when text-shadows were done differently inside WebCore (before it
supported multiple text-shadows perhaps?).  Anyway, my patch seems to roughly
match what other ports do for text shadows.  I didn't remove the commented-out
function yet since it seems to have a blur implementation and my patch doesn't
support blurring yet.

More information about the webkit-reviews mailing list