[webkit-reviews] review denied: [Bug 19652] [CAIRO] wrong drawing of border-image : [Attachment 21823] border-image

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 18 22:54:43 PDT 2008

Mark Rowe (bdash) <mrowe at apple.com> has denied Mark Rowe (bdash)
<mrowe at apple.com>'s request for review:
Bug 19652: [CAIRO] wrong drawing of border-image

Attachment 21823: border-image

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
This call to cairo_destroy can pass an uninitialized value for cr_surface which
I doubt is safe:

+    cairo_destroy(cr_surface);

Why does the call to cairo_destroy need to be outside the body of the if block
where cr_surface is used?  The naming of cr_surface seems like poor choice too:
 both surface and cr_surface are cairo types, and I can't see any particular
significance to the cr_ prefix.

More information about the webkit-reviews mailing list