[webkit-reviews] review requested: [Bug 14360] JavaScript source view should be syntax highlighted : [Attachment 21822] delete

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 18 13:28:36 PDT 2008


Keishi Hattori <casey.hattori at gmail.com> has asked  for review:
Bug 14360: JavaScript source view should be syntax highlighted
https://bugs.webkit.org/show_bug.cgi?id=14360

Attachment 21822: delete
https://bugs.webkit.org/attachment.cgi?id=21822&action=edit

------- Additional Comments from Keishi Hattori <casey.hattori at gmail.com>
I think writing like this will make it easy to rewrite into lazy highlighting.
	function deleteContinueFlags(cell)
	{
	    if (cell) {
		delete cell._commentContinues;
		delete cell._singleQuoteStringContinues;
		delete cell._doubleQuoteStringContinues;
		delete cell._regexpContinues;
	    }
	}
	
	for (var i = 0; i < rowsLength; ++i) {
	    var row = rows[i];
	    var cell = row.getElementsByTagName("td")[1];
	    if (!cell)
		continue;
	    this._syntaxHighlightJavascriptLine(cell, previousCell);
	    deleteContinueFlags(previousCell);
	    previousCell = cell;
	}
	deleteContinueFlags(previousCell);


More information about the webkit-reviews mailing list