[webkit-reviews] review requested: [Bug 12425] border-radius not applied to fieldset with legend : [Attachment 21812] Implements border radius logic for a fieldset, based off RenderObject's implementation

[bugzilla-daemon at webkit.org]

Alex Taylor <darwin at milliamp.org> has asked  for review:
Bug 12425: border-radius not applied to fieldset with legend
https://bugs.webkit.org/show_bug.cgi?id=12425

Attachment 21812: Implements border radius logic for a fieldset, based off
RenderObject's implementation
https://bugs.webkit.org/attachment.cgi?id=21812&action=edit

------- Additional Comments from Alex Taylor <darwin at milliamp.org>
This patch implements the border radius logic based off RenderObject's
implementation but with parts that make sure the area around the legend is
excluded. This just extends the current "draw the border pieces that don't
overlap the legend" logic with some additional trigonometry to make the arcs
shorter if the legend will overlap rather than just not rendering a corner
piece.

This seems to work well but I think we should instead make the legend be an
clipped region of the border rather than 'avoiding drawing the border where the
legend is' as the current (and this) implementation does. If that is the case,
this entire function can hopefully be removed and the RenderObject version
used, that would be a separate bug though.

Firefox uses the clipped method, they clip the border around the bounding box
of the legend element.

This patch is for review only, no tests have been included in the patch.