[webkit-reviews] review granted: [Bug 17257] start ref counts at 1 instead of 0 for speed : [Attachment 21722] patch that converts StyleBase and classes derived from it

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Darin Adler <darin at apple.com>'s request
for review:
Bug 17257: start ref counts at 1 instead of 0 for speed
https://bugs.webkit.org/show_bug.cgi?id=17257

Attachment 21722: patch that converts StyleBase and classes derived from it
https://bugs.webkit.org/attachment.cgi?id=21722&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
I think it would be better to make the computedStyle function be called
CSSComputedStyleDeclaration::create.  Is there a reason to change the style for
it?

Can this be done with a default value for  charset of String()?

+    static PassRefPtr<CSSStyleSheet> create(Node* ownerNode, const String&
href)
+    {
+	 return adoptRef(new CSSStyleSheet(ownerNode, href, String()));
+    }
+    static PassRefPtr<CSSStyleSheet> create(Node* ownerNode, const String&
href, const String& charset)
+    {
+	 return adoptRef(new CSSStyleSheet(ownerNode, href, charset));
+    }


r=me