[webkit-reviews] review denied: [Bug 19470] Null pointer dereferences on a document with no documentElement : [Attachment 21691] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 14 01:02:38 PDT 2008

Darin Adler <darin at apple.com> has denied danceoffwithyourpantsoff
<danceoffwithyourpantsoff at gmail.com>'s request for review:
Bug 19470: Null pointer dereferences on a document with no documentElement

Attachment 21691: Proposed patch

------- Additional Comments from Darin Adler <darin at apple.com>
+  if (window.LayoutTestController)
+    window.LayoutTestController.dumpAsText();

The letter "L" has to be lowercase here, or it won't work.

Added: svn:eol-style
   + LF

Why LF style? We don't use that style for other files.

+	     if (const Element* doc = static_cast<const
+		 return doc->isDefaultNamespace(namespaceURI);

We normally use "doc" for "document". Using "doc" for "documentElement" is
unnecessarily confusing. Maybe "de" or "documentElement" or even just "e" or
"element". Also really no need for const in the type of the local variable.

review- because of the letter "L" problem. I have no idea why the test worked!

Do you really want to go without a name in the change log? I'd prefer
"Anonymous" to "danceoff" for the name here.

More information about the webkit-reviews mailing list