[webkit-reviews] review requested: [Bug 18941] WebView fails to load if opened from a blocking JS call in a timer. : [Attachment 21681] Proposed fix for comments

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has asked  for review:
Bug 18941: WebView fails to load if opened from a blocking JS call in a timer.
https://bugs.webkit.org/show_bug.cgi?id=18941

Attachment 21681: Proposed fix for comments
https://bugs.webkit.org/attachment.cgi?id=21681&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
This patch fixes the attached test case. Basically the layout and loading
related Timers were not firing in the nested event loop that the plugin was
spinning up to block the calling JavaScript. I added the
TimerBase::fireTimersInNestedEventLoop() call where we are calling native code
for all the bindings (like we do with JSLock::DropAllLocks).

Is this the right fix?

Should we call TimerBase::fireTimersInNestedEventLoop() for all/some delegate
methods too?