[webkit-reviews] review granted: [Bug 19465] Cursor sometimes gets 'stuck' in textareas when trying to navigate with arrow keys : [Attachment 21659] Patch for stuck cursor with updated test case

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jonathon Jongsma
<jonathon.jongsma at collabora.co.uk>'s request for review:
Bug 19465: Cursor sometimes gets 'stuck' in textareas when trying to navigate
with arrow keys
https://bugs.webkit.org/show_bug.cgi?id=19465

Attachment 21659: Patch for stuck cursor with updated test case
https://bugs.webkit.org/attachment.cgi?id=21659&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I think the test would be better if it got the value of textarea.selectionStart
at the end of the test and wrote it out. Depending on the editing delegate
values is too subtle. In fact, I'd prefer not to log the editing delegate
messages -- but I can't remember what turns that logging on! Maybe it's
something about being inside the editing directory?

+    layoutTestController.dumpAsText();

The normal idiom for this is to check for the existence of layoutTestController
first, before using it, with if (window.layoutTestController). Your version
will fail with an exception when it hits that line of code when run in the
browser.

Also, the test needs to be more self documenting. It should indicate what
successful output looks like.

I'm going to say review+, but feel free to make another pass at this with a
better test.