[webkit-reviews] review requested: [Bug 19465] Cursor sometimes gets 'stuck' in textareas when trying to navigate with arrow keys : [Attachment 21659] Patch for stuck cursor with updated test case

[bugzilla-daemon at webkit.org]

Jonathon Jongsma <jonathon.jongsma at collabora.co.uk> has asked Darin Adler
<darin at apple.com> for review:
Bug 19465: Cursor sometimes gets 'stuck' in textareas when trying to navigate
with arrow keys
https://bugs.webkit.org/show_bug.cgi?id=19465

Attachment 21659: Patch for stuck cursor with updated test case
https://bugs.webkit.org/attachment.cgi?id=21659&action=edit

------- Additional Comments from Jonathon Jongsma
<jonathon.jongsma at collabora.co.uk>
Here's another attempt.  Thanks for you guidance on this.  I modified the test
to use layoutTestController.dumpAsText() and I removed the call to move forward
by sentence.  Instead I just set the initial selection partway through the
first line of text (it's only important that it be past the end of the numbered
lines that follow.  

As I'm not particularly familiar with the test infrastructure, I wasn't exactly
sure what to expect for output of the dumpAsText() command.  The output before
the patch is 6 lines of 'EDITING DELEGATE:
webViewDidChangeSelection:WebViewDidChangeSelectionNotification', and after the
patch it's 8 lines (since the cursor position no longer gets suck at the end of
'3. ').  So it seems that the output is adequate to detect the broken behavior.


I did not remove the runEditingTest() infrastructure from the test as I did not
know a way to send down-arrow key events without it (I'm afraid I'm not
particularly familiar with javascript).  If you can easily replace it with
something simpler, feel free, but I thought I'd leave it how it is since it
seems to work.