[webkit-reviews] review requested: [Bug 19408] Constant folding in parser : [Attachment 21658] Const.Folding.v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 12 03:46:49 PDT 2008

Gabor Loki <loki at inf.u-szeged.hu> has asked  for review:
Bug 19408: Constant folding in parser

Attachment 21658: Const.Folding.v2

------- Additional Comments from Gabor Loki <loki at inf.u-szeged.hu>
This patch adds a lightweight constant folding algorithm.

The algorithm handles simple folding cases (like the left and the right side of
a binary operator are Number: CONST * CONST). It does not do expensive tree
rotation or operand swapping to optimize constant folding. So such as
expression: CONST * VAR * CONST will never be folded.

This patch is against rev. 34508.
The update of MSVC and XCode project files are missing.

No new regression found (with run-javascriptcore-tests).
SunSpider says: 1.019x as fast, 3273.1ms +/- 0.6%, 3212.9ms +/- 0.2%,

More information about the webkit-reviews mailing list