[webkit-reviews] review granted: [Bug 8008] Textarea uses the I-beam ("text") cursor when disabled, not "default" : [Attachment 21103] Better check

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 11 15:00:22 PDT 2008

Darin Adler <darin at apple.com> has granted Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 8008: Textarea uses the I-beam ("text") cursor when disabled, not "default"

Attachment 21103: Better check

------- Additional Comments from Darin Adler <darin at apple.com>
+	     if ((editable || (renderer && renderer->isText() &&
node->canStartSelection())) && !inResizer && !scrollbar &&

What guarantees that renderer->containingBlock() is non-zero?

What guarantees that renderer->containingBlock()->node() is non-zero?

Is there any way to make a regression test for this? Can we come up with a
regression testing system for cursors?

Assuming the answers to all these questions are good (something, something, and
some good excuse for not being able to test), then r=me.

More information about the webkit-reviews mailing list