[webkit-reviews] review denied: [Bug 19200] *.in files should embed more information : [Attachment 21593] Fourth part: move more parameters

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 10 10:22:39 PDT 2008

Eric Seidel <eric at webkit.org> has denied Julien Chaffraix
<julien.chaffraix at gmail.com>'s request for review:
Bug 19200: *.in files should embed more information

Attachment 21593: Fourth part: move more parameters

------- Additional Comments from Eric Seidel <eric at webkit.org>
attrs shoudl have a null namespace by default.	SVG Attrs do not have a

I don't think generateFactory and generateWrapperFactory shoudl be in these
text files.  Those should be controlled by the scripts.  (i.e. you can generate
one of htem if you want using the scripts).

The part of this which seems good in the files is the guardFactoryWith logic.

We can talk about it more over IRC if you like.

More information about the webkit-reviews mailing list