[webkit-reviews] review granted: [Bug 17531] Add interactive mode to testkjs : [Attachment 21590] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 9 06:51:08 PDT 2008

Darin Adler <darin at apple.com> has granted Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>'s request for review:
Bug 17531: Add interactive mode to testkjs

Attachment 21590: Proposed patch

------- Additional Comments from Darin Adler <darin at apple.com>
+static const char* interactivePrompt = "> ";

This should be static const char[] or static const char* const. The declaration
as-is asks for a non-const global pointing to a const string.

+    fprintf(stderr, "	-p	   Prints formatted source code\n");

I think this option is a little silly now that it does no formatting and just
spits the code out as-is.


More information about the webkit-reviews mailing list