[webkit-reviews] review granted: [Bug 17421] Lack of end tag of SELECT element causes inaccessible (blank) a rest of a page rendered : [Attachment 21456] Fix for the bug reflecting the latest HTML5 spec changes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 8 17:59:08 PDT 2008


Darin Adler <darin at apple.com> has granted Robert Blaut <webkit at blaut.biz>'s
request for review:
Bug 17421: Lack of end tag of SELECT element causes  inaccessible (blank) a
rest of a page rendered
http://bugs.webkit.org/show_bug.cgi?id=17421

Attachment 21456: Fix for the bug reflecting the latest HTML5 spec changes
http://bugs.webkit.org/attachment.cgi?id=21456&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This patch is good.

What would make it better would be to add a call to reportError here so the web
inspector would explain the error in the page. I think the call would be:

    reportError(MisplacedContentRetryError, &localName, &currentTagName)

I also think that it would be better to have a test with a text result rather
than a Mac-specific render tree result.

r=me, as-is


More information about the webkit-reviews mailing list