[webkit-reviews] review granted: [Bug 18965] Allow platform specific adjustments to the default style sheet : [Attachment 21387] Allow platform specific adjustments to the default style sheet

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 8 14:02:17 PDT 2008


Darin Adler <darin at apple.com> has granted Tor Arne Vestbø
<tavestbo at trolltech.com>'s request for review:
Bug 18965: Allow platform specific adjustments to the default style sheet
http://bugs.webkit.org/show_bug.cgi?id=18965

Attachment 21387: Allow platform specific adjustments to the default style
sheet
http://bugs.webkit.org/attachment.cgi?id=21387&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+#include "CSSStyleSheet.h"

This include is not needed in RenderTheme.cpp.

+void RenderTheme::adjustDefaultStyleSheet(CSSStyleSheet* style) {}

For people compiling with unused argument warnings it would be better to omit
the word "style".

I don't see any major benefit to using the "all in one line" format here. This
could just be laid out in the normal way.

Seems OK, r=me


More information about the webkit-reviews mailing list