[webkit-reviews] review denied: [Bug 17557] incorrect results for css2.1 layout tests that use setTimeout in body onload event : [Attachment 21270] Patch for the 2 affected tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 8 12:50:08 PDT 2008


Darin Adler <darin at apple.com> has denied 's request for review:
Bug 17557: incorrect results for css2.1 layout tests that use setTimeout in
body onload event
http://bugs.webkit.org/show_bug.cgi?id=17557

Attachment 21270: Patch for the 2 affected tests
http://bugs.webkit.org/attachment.cgi?id=21270&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Once I applied the patch and put these diffs into a form I could read, I could
tell they were incorrect. I was wrong to say r=me before!

The meta-refresh-vs-open.html change was only adding a call to notifyDone
inside the onload handler. That's not going to fix anything in the success
case, since the onload handler only runs if the test fails.

The http/tests/navigation/onload-navigation-iframe-timeout.html was no change
at all, only a whitespace tweak.


More information about the webkit-reviews mailing list