[webkit-reviews] review denied: [Bug 18393] Move POST cache policy from platform dependent file : [Attachment 20799] new patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 8 12:38:33 PDT 2008

Darin Adler <darin at apple.com> has denied 's request for review:
Bug 18393: Move POST cache policy from platform dependent file

Attachment 20799: new patch

------- Additional Comments from Darin Adler <darin at apple.com>
This patch, as is, breaks the Mac platform. That's because the request sent
into sendSynchronousRequest won't have the cache policy set to

The rearranged code sets the policy after the call, whereas the old code set it

I think that the old behavior where the cache policy was set to
ReturnCacheDataDontLoad for the navigation itself was actually a bug -- I think
the intent was to set it only for the "willLoadFromCache" check itself.

review- because we don't want to break the Mac. I won't try to rework this
myself, but it should be relatively straightforward.

More information about the webkit-reviews mailing list