[webkit-reviews] review granted: [Bug 17324] Remove PLATFORM ifdefs from ContextMenu.cpp : [Attachment 21560] Move webkit code to ContextMenuClient
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jun 7 10:36:17 PDT 2008
Eric Seidel <eric at webkit.org> has granted Christian Dywan
<christian at imendio.com>'s request for review:
Bug 17324: Remove PLATFORM ifdefs from ContextMenu.cpp
http://bugs.webkit.org/show_bug.cgi?id=17324
Attachment 21560: Move webkit code to ContextMenuClient
http://bugs.webkit.org/attachment.cgi?id=21560&action=edit
------- Additional Comments from Eric Seidel <eric at webkit.org>
Assuming the code still works, the move looks fine.
new WebKit::ContextMenuClient (webView)
seems to have an extra space.
And:
+ WebKitWebView *m_webView;
Is in a WebCore file, but puts the * in the opposite place as the rest of
WebCore. :)
It would be nice to land with those to changes, but in general looks fine.
More information about the webkit-reviews
mailing list