[webkit-reviews] review requested: [Bug 19415] CSSParser needs a bath : [Attachment 21558] Reviewed by ap.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 7 03:07:38 PDT 2008


Eric Seidel <eric at webkit.org> has asked  for review:
Bug 19415: CSSParser needs a bath
http://bugs.webkit.org/show_bug.cgi?id=19415

Attachment 21558:	  Reviewed by ap.
http://bugs.webkit.org/attachment.cgi?id=21558&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>

	More cleanup to CSSParser, rename mediaQuery to m_mediaQuery
	Remove CSSParser::current and CSSParser::currentParser and use
	the magic of YYLEX_PARAM instead.

	* css/CSSParser.cpp:
	(WebCore::enterGeneratedParser):
	(WebCore::CSSParser::parseSheet):
	(WebCore::CSSParser::parseRule):
	(WebCore::CSSParser::parseValue):
	(WebCore::CSSParser::parseColor):
	(WebCore::CSSParser::parseDeclaration):
	(WebCore::CSSParser::parseMediaQuery):
	* css/CSSParser.h:
---
 WebCore/ChangeLog	   |   18 ++++++++++++++++++
 WebCore/css/CSSGrammar.y  |   14 +++++++++++---
 WebCore/css/CSSParser.cpp |   41 +++++------------------------------------
 WebCore/css/CSSParser.h   |	6 +-----
 4 files changed, 35 insertions(+), 44 deletions(-)


More information about the webkit-reviews mailing list