[webkit-reviews] review granted: [Bug 19415] CSSParser needs a bath : [Attachment 21557] even more cssparser cleanup
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jun 7 02:59:34 PDT 2008
Alexey Proskuryakov <ap at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 19415: CSSParser needs a bath
http://bugs.webkit.org/show_bug.cgi?id=19415
Attachment 21557: even more cssparser cleanup
http://bugs.webkit.org/attachment.cgi?id=21557&action=edit
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+ parsedValue = new
CSSFontFaceSrcValue(KURL(m_styleSheet->baseURL(), value).string(), false);
StyleBase::baseURL() returns KURL, you can avoid copying here (repeated several
times).
+ if (!m_styleSheet->isCSSStyleSheet())
return 0;
This looks like it should be omitted (also, more than once).
r=me
More information about the webkit-reviews
mailing list