[webkit-reviews] review denied: [Bug 19415] CSSParser needs a bath : [Attachment 21548] More cleanup to CSSParser
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jun 7 01:00:08 PDT 2008
Alexey Proskuryakov <ap at webkit.org> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 19415: CSSParser needs a bath
http://bugs.webkit.org/show_bug.cgi?id=19415
Attachment 21548: More cleanup to CSSParser
http://bugs.webkit.org/attachment.cgi?id=21548&action=edit
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I do not think it's such a great idea to wrap CSSParser::currentParser
manipulation in a function, when it can be just removed (see how it's done in
JSC, YYLEX_PARAM and YYPARSE_PARAM).
r- for you to consider doing it this way.
rs=me on m_mediaQuery renaming.
More information about the webkit-reviews
mailing list