[webkit-reviews] review denied: [Bug 17051] safari should treat "url()" as a valid CSS value : [Attachment 21531] another attempt to format patch properly

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 6 15:08:32 PDT 2008

Darin Adler <darin at apple.com> has denied Bradley Meck <genisis329 at gmail.com>'s
request for review:
Bug 17051: safari should treat "url()" as a valid CSS value

Attachment 21531: another attempt to format patch properly

------- Additional Comments from Darin Adler <darin at apple.com>
WebCore/ChangeLog still doesn't include the URL of te bug.

WebKit/ChangeLog still has a gratuitous change in it (just a blank line, so

LayoutTests/ChangeLog mentions the ChangeLog itself as one of the files

The LayoutTests patch includes the new test in its old path location,
LayoutTests/css2.1/t17051-url-empty.html, and doesn't include the expected
results for the new test.

I'm sorry -- I know you're trying hard to get this right but this is still not
ready to land.

review- because of the LayoutTests problems. The other problems are minor.

More information about the webkit-reviews mailing list