[webkit-reviews] review denied: [Bug 19125] [Qt] add functions to get/set the zoom level : [Attachment 21271] Add functions to get/set the zoom level

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 6 01:37:37 PDT 2008

Simon Hausmann <hausmann at webkit.org> has denied Siraj razick
<siraj.razick at collabora.co.uk>'s request for review:
Bug 19125: [Qt] add functions to get/set  the zoom level

Attachment 21271: Add functions to get/set the zoom level

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
In principle I agree with the patch, but I see two problems:

1) Documentation is missing for this property.

2) The return value of Frame::zoomFactor() can be the text size multiplier or
the zoom factor. I think we should use the newly added pageZoomFactor() and
textZoomFactor() getters. But I'm not sure what to do about the two conflicting
and symmetry. Either way we have to document the interaction of the two
properties or how they exclude each other.

Another option is to add support for both...

So r- because this needs more work, but don't let that discourage you! It's
great that you've started on this missing feature :)

More information about the webkit-reviews mailing list