[webkit-reviews] review granted: [Bug 19403] ASSERT in InsertIntoTextNodeCommand::InsertIntoTextNodeCommand during RemoveFormat call : [Attachment 21519] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 5 21:32:18 PDT 2008


Eric Seidel <eric at webkit.org> has granted Justin Garcia
<justin.garcia at apple.com>'s request for review:
Bug 19403: ASSERT in InsertIntoTextNodeCommand::InsertIntoTextNodeCommand
during RemoveFormat call
http://bugs.webkit.org/show_bug.cgi?id=19403

Attachment 21519: patch
http://bugs.webkit.org/attachment.cgi?id=21519&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks good.  The if (string.isEmpty()) should have a comment before it
explaning "why", since I'm not sure it will be clear to either of us why it's
there in 9 months. :)


If you strongly disagree I'm fine w/ you to landing w/o comment.  I don't need
to see your final patch again either way. :)


More information about the webkit-reviews mailing list