[webkit-reviews] review requested: [Bug 19331] Drag and drop of links in edit mode violates assert in MoveSelectionCommand::doApply() : [Attachment 21509] Expand the selection to the enclosing anchor element at the drag launch per comment by Olliver

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 5 08:11:38 PDT 2008


Jonathon Jongsma <jonathon.jongsma at collabora.co.uk> has asked Oliver Hunt
<oliver at apple.com> for review:
Bug 19331: Drag and drop of links in edit mode violates assert in
MoveSelectionCommand::doApply()
http://bugs.webkit.org/show_bug.cgi?id=19331

Attachment 21509: Expand the selection to the enclosing anchor element at the
drag launch per comment by Olliver
http://bugs.webkit.org/attachment.cgi?id=21509&action=edit

------- Additional Comments from Jonathon Jongsma
<jonathon.jongsma at collabora.co.uk>
Well, Here's a modified patch that expands the selection at the drag launch
site as you suggested.	I'm not convinced this is the ideal solution however. 
In this case, if you start a drag and then abort it (e.g. by pressing 'esc'),
you'll end with the link selected when it wasn't selected before the drag. 
This doesn't seem quite right to me, but I guess it doesn't seem too bad either
as it's the same behavior that exists for images.


More information about the webkit-reviews mailing list