[webkit-reviews] review requested: [Bug 16631] security/frameNavigation tests should test for DENIED cases : [Attachment 21507] More test coverage

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 5 04:36:14 PDT 2008

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 16631: security/frameNavigation tests should test for DENIED cases

Attachment 21507: More test coverage

------- Additional Comments from Adam Barth <abarth at webkit.org>
This patch significantly improves our LayoutTest coverage for navigation tests.
 The patch tries each method of navigation (assigning to location, window.open,
clicking hyperlinks, submitting forms, and plugs calling getURL) in a variety
of frame configurations.  The tests reveal a bug in our plugin code where we
don't properly set the opener of frames we create, but we should fix that in a
separate bug.

More information about the webkit-reviews mailing list