[webkit-reviews] review granted: [Bug 12983] Web Inspector break on the debugger keyword : [Attachment 21475] Patch-fu!

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 3 06:54:40 PDT 2008

Timothy Hatcher <timothy at hatcher.name> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 12983: Web Inspector break on the debugger keyword

Attachment 21475: Patch-fu!

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
I would recommend "Breakpoint" instead of "BreakPoint" to match the inspector
and Xcode.

+// about to leave a stack frame (i.e. return from a function)
+- (void)webView:(WebView *)webView   didReachBreakPoint:(WebScriptCallFrame

Also that comment is not correct for the method you added.

More information about the webkit-reviews mailing list