[webkit-reviews] review granted: [Bug 19363] Compiler error in Entity.h : [Attachment 21470] proposed temporary fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 3 00:56:51 PDT 2008

Alexey Proskuryakov <ap at webkit.org> has granted Alexander Vassilev
<avasilev at voipgate.com>'s request for review:
Bug 19363: Compiler error in Entity.h

Attachment 21470: proposed temporary fix

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I think that this is basically the right fix. I'll land it with some

+    Entity(): ContainerNode(0){};

We'd write this as

+    Entity() : ContainerNode(0) {}

Also, the constructor should be private for clarity.

More information about the webkit-reviews mailing list