[webkit-reviews] review requested: [Bug 18428] Patch to support building wxWebKit on mingw : [Attachment 21462] path to fix a compilation error and disable a runtime assertion until its fixed
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 2 07:00:40 PDT 2008
Alexander Vassilev <avasilev at voipgate.com> has asked for review:
Bug 18428: Patch to support building wxWebKit on mingw
http://bugs.webkit.org/show_bug.cgi?id=18428
Attachment 21462: path to fix a compilation error and disable a runtime
assertion until its fixed
http://bugs.webkit.org/attachment.cgi?id=21462&action=edit
------- Additional Comments from Alexander Vassilev <avasilev at voipgate.com>
1 Fix for broken compilation in Entity.h - WebCore::Entity::Entity having a
default constructor but inherits from a class with no default constructor. This
is rather a temporary hack than a fix, but since the Entity calss is only a
stub that prevents compilation errors it probably should be ok. Hopefully
someone fixes this the right way
2 Assertion failure in FontCache.cpp under MINGW - disabled the ASSERT macro
for this file only, as a temporary solution
Probably this patch should be submitted as a solution to a separate bug, but
since I have encountered the problem while compiling with MINGW, hte problem
could be manifesting only under MINGW, even though its seems not
compiler-related.
More information about the webkit-reviews
mailing list