[webkit-reviews] review denied: [Bug 20245] WinLauncher does not start in WebKit-debug right out of the box. : [Attachment 22587] Just following arobens directions for fixing WinLauncher.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 31 14:29:42 PDT 2008


Adam Roben (aroben) <aroben at apple.com> has denied Stefan Landvogt
<stefan.landvogt at gmail.com>'s request for review:
Bug 20245: WinLauncher does not start in WebKit-debug right out of the box.
https://bugs.webkit.org/show_bug.cgi?id=20245

Attachment 22587: Just following arobens directions for fixing WinLauncher.
https://bugs.webkit.org/attachment.cgi?id=22587&action=edit

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
Thanks for the patch!

Two changes are needed before we can land this:

1. The change you made to the project file needs to be made for all
configurations. You should choose "All Configurations" from the "Configuration"
drop-down in the "Project Properties" dialog, then make the change.

2. You need to write a ChangeLog entry. See
<http://webkit.org/coding/contributing.html> for instructions on how to do so.


More information about the webkit-reviews mailing list