[webkit-reviews] review denied: [Bug 20224] Include the Writing Direction sub-menu in the context menu of the Qt port. : [Attachment 22550] Implements inclusion of the Writing Direction sub-menu.

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Erik L. Bunce
<elbunce at thehive.com>'s request for review:
Bug 20224: Include the Writing Direction sub-menu in the context menu of the Qt
port.
https://bugs.webkit.org/show_bug.cgi?id=20224

Attachment 22550: Implements inclusion of the Writing Direction sub-menu.
https://bugs.webkit.org/attachment.cgi?id=22550&action=edit

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I agree with the patch in principle, but I think the #ifdefs are not entirely
correct. Revision 34426 accidentially put the writing direction menu item into
a PLATFORM(MAC) block where previously it was effectively !PLATFORM(GTK).
Before the  change it was available on all platforms (mac, win, wx, qt, etc.)
except Gtk, now it's only available for the mac. Can you fix it that way around
using !PLATFORM(GTK) and refer to change 34426 in the change log?

Thanks :)