[webkit-reviews] review granted: [Bug 20238] Minor bugs with style editing in the Inspector : [Attachment 22572] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 30 19:51:11 PDT 2008

Adam Roben (aroben) <aroben at apple.com> has granted Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 20238: Minor bugs with style editing in the Inspector

Attachment 22572: Proposed patch

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
-	 // Lie about out children to prevent toggling on click.
+	 this.wasExpanded = this.expanded;
+	 // Lie about our children to prevent expanding on double click and to
collapse shorthands.
+	 this.reallyHasChildren = this.hasChildren;
	 this.hasChildren = false;
	 if (!selectElement)
@@ -563,23 +564,26 @@ WebInspector.StylePropertyTreeElement.prototype = {
	 window.getSelection().setBaseAndExtent(selectElement, 0,
selectElement, 1);
-	 WebInspector.startEditing(this.listItemElement,
this.editingCommitted.bind(this), this.editingCancelled.bind(this),
+	 WebInspector.startEditing(this.listItemElement,
this.editingCommitted.bind(this), this.editingCancelled.bind(this));

I guess you could pass the information along in the context parameter to
startEditing instead of storing it on this. That would save you from having to
delete the properties later. But it doesn't matter too much either way.


More information about the webkit-reviews mailing list