[webkit-reviews] review granted: [Bug 20209] Atomize constant strings : [Attachment 22537] fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 29 15:52:22 PDT 2008

Geoffrey Garen <ggaren at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 20209: Atomize constant strings

Attachment 22537: fix

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Note that the patch I suggested to convert a['s'] to a.s during codegen would
also fix this particular test case.

+    // String literals are atomized (internalized) in the identifier map.

Probably better to state the why here, rather than the what. For example, "We
atomize constant strings, in case they're later used in property lookup."

+	 a script contains multiple identical strings that are used as keys
keys to identify

Typo: "keys keys" should be "keys."

Please add a bugzilla link to the ChangeLog.


More information about the webkit-reviews mailing list