[webkit-reviews] review granted: [Bug 20013] Windows AX huerusitics are poor : [Attachment 22470] First chunk of patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 29 13:47:23 PDT 2008

Eric Seidel <eric at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 20013: Windows AX huerusitics are poor

Attachment 22470: First chunk of patch

------- Additional Comments from Eric Seidel <eric at webkit.org>
I still think that:
+	 elementHashSet.add(bTag.toString());

probably don't need the explicit .toString() calls.

+	 elementHashSet.add(bTag);
Should "just work".  BUt maybe I'm wrong.

+	     String elementTitle = childrenVector[i]->title();
+	     append(elementText, elementTitle);
Can be written:
+	     append(elementText, childrenVector[i]->title());
Either way is fine.  :)

Sad that we have to copy a string here:
+	 return String::adopt(elementText).stripWhiteSpace();
But it should be fine.

No { } around single line if clauses:
+    if (m_renderer->isBlockFlow()) {
+	 return m_renderer->isAnonymousBlock();
+    }

This change looks great to me!	I'll ask Jon to look over it one more time.

More information about the webkit-reviews mailing list