[webkit-reviews] review denied: [Bug 19775] Alignment problems on Sparc : [Attachment 22105] Patch I'm applying to the debian package

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has denied Mike Hommey
<mh+webkit at glandium.org>'s request for review:
Bug 19775: Alignment problems on Sparc
https://bugs.webkit.org/show_bug.cgi?id=19775

Attachment 22105: Patch I'm applying to the debian package
https://bugs.webkit.org/attachment.cgi?id=22105&action=edit

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
This patch a) breaks the build on Mac OS X, and b) will almost certainly lead
to incorrect code generation due to the strict aliasing violations it
introduces.

Here are some of the errors that are produced:

./wtf/Platform.h:198:5: error: "__BYTE_ORDER" is not defined
./wtf/Platform.h:198:21: error: "__BIG_ENDIAN" is not defined

./wtf/Vector.h: In member function 'T* WTF::VectorBuffer<T,
inlineCapacity>::inlineBuffer() [with T = KJS::Register, long unsigned int
inlineCapacity = 8ul]':
./wtf/Vector.h:345:   instantiated from 'WTF::VectorBuffer<T,
inlineCapacity>::VectorBuffer() [with T = KJS::Register, long unsigned int
inlineCapacity = 8ul]'
./wtf/Vector.h:407:   instantiated from 'WTF::Vector<T,
inlineCapacity>::Vector() [with T = KJS::Register, long unsigned int
inlineCapacity = 8ul]'
/Volumes/Data/Users/mrowe/Documents/Work/WebKit-git/OpenSource/JavaScriptCore/k
js/ArgList.h:49:   instantiated from here
./wtf/Vector.h:389: warning: dereferencing type-punned pointer will break
strict-aliasing rules