[webkit-reviews] review granted: [Bug 20010] [Qt] Add API access to scrolling : [Attachment 22474] Re-made the patch with simplified API, r35344

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 26 06:32:18 PDT 2008


Simon Hausmann <hausmann at webkit.org> has granted marcoil
<marc.ordinasillopis at collabora.co.uk>'s request for review:
Bug 20010: [Qt] Add API access to scrolling
https://bugs.webkit.org/show_bug.cgi?id=20010

Attachment 22474: Re-made the patch with simplified API, r35344
https://bugs.webkit.org/attachment.cgi?id=22474&action=edit

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Patch looks good. But when landing two _tiny_ fixes should be done:

1) There's a const missing before the QSize& in setScrollOffset

2) The documentation of scroll() needs a \since 4.5 tag


More information about the webkit-reviews mailing list