[webkit-reviews] review requested: [Bug 20175] Fixes for Windows and non-AllInOne file build with SamplingTool, plus review fixes. : [Attachment 22485] patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has asked  for review:
Bug 20175: Fixes for Windows and non-AllInOne file build with SamplingTool,
plus review fixes.
https://bugs.webkit.org/show_bug.cgi?id=20175

Attachment 22485: patch
https://bugs.webkit.org/attachment.cgi?id=22485&action=edit

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
I think this should fix the issues for the last patch (
https://bugs.webkit.org/show_bug.cgi?id=19865 ).

I hope adding ENABLE_SAMPLING_TOOL to config.h (defaulted to off, of course)
looks sensible – it ensures the switch is made available in all .cpps compiled,
and makes enabling the tool nice and straightforward.

WebKit tests pass, jsc built and tested on windows, no degradation on
SunSpider.