[webkit-reviews] review denied: [Bug 20156] [Qt] build failure after r35293 : [Attachment 22461] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 24 16:02:25 PDT 2008


Eric Seidel <eric at webkit.org> has denied Gabor Loki <loki at inf.u-szeged.hu>'s
request for review:
Bug 20156: [Qt] build failure after r35293
https://bugs.webkit.org/show_bug.cgi?id=20156

Attachment 22461: proposed fix
https://bugs.webkit.org/attachment.cgi?id=22461&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Can't do that:
-#include <JavaScriptCore/JSBase.h>
-#include <JavaScriptCore/JSValueRef.h>
+#include "JSBase.h"
+#include "JSValueRef.h"
 

You'll have to use some sort of ForwardingHeaders solution on linux.  See
JavaScriptCore/ForwardingHeaders or WebCore/ForwardingHeaders


More information about the webkit-reviews mailing list