[webkit-reviews] review granted: [Bug 19391] Dynamically created SVG script tags fail to execute : [Attachment 22259] Some more tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 24 11:49:36 PDT 2008

Eric Seidel <eric at webkit.org> has granted Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 19391: Dynamically created SVG script tags fail to execute

Attachment 22259: Some more tests

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think it's better to be explicit about what scriptTag it is in XMLTokenizer,
I would prefer you leave the HTMLNames:: when the next line is
SVGNames::scriptTag. :)

Looks fine.  Wow, I wish that SVGScriptElement and HTMLScriptElement could
share more code.  I think our current split solution is going to lead to lots
of copy/paste bugs.

More information about the webkit-reviews mailing list