[webkit-reviews] review granted: [Bug 19588] CRASH doing open() on destroyed window : [Attachment 22432] Updated version: use top() and cover the other crash pointed by Eric

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 23 13:17:35 PDT 2008


Eric Seidel <eric at webkit.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 19588: CRASH doing open() on destroyed window
https://bugs.webkit.org/show_bug.cgi?id=19588

Attachment 22432: Updated version: use top() and cover the other crash pointed
by Eric
https://bugs.webkit.org/attachment.cgi?id=22432&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks fine, but:
if (page) {
 184	     for (Frame* frame = page

should change to be an early return:

if (!page)
   return 0;


More information about the webkit-reviews mailing list